fix(consensus): prevent timestamp overflow crash from malicious proposals#38
Merged
fix(consensus): prevent timestamp overflow crash from malicious proposals#38
Conversation
calbera
force-pushed
the
fix-timestamp-overflow
branch
from
cd44b33 to
697dfa4
Compare
fridrik01
approved these changes
Apr 16, 2026
| lowerBound, upperBound := cs.timelyProposalMargins() | ||
| // TODO: use Warn level once available. | ||
| // Use .String() to avoid passing a raw time.Duration to the logger, | ||
| // which can panic in some logger implementations (e.g. phuslu/log) |
There was a problem hiding this comment.
If thats the case, we should really switch out from phuslu in beaconkit, no need to let logger panic in that case
bar-bera
reviewed
Apr 17, 2026
Co-authored-by: bar-bera <bearbaresco@berachain.com> Signed-off-by: Cal Bera <calbera@berachain.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevents a panic in logger (from absurdly large timestamp) which could crash consensus